SCI: Add support for Ultimate Kings Quest 4 with Amiga sounds and Munt Support

[TarkinMX]

Requesting support for Ultimate Kings Quest 4 with Amiga sounds and Munt which can be found at the bottom of Collector's first post at ​http://www.sierrahelp.com/forums/viewtopic.php?f=24&t=3925. Using this installer patches the game to version 1.1 and adds the additional sounds from the Amiga version of the game. The installer sets up DOSBox for the user and plays fine. I'm running ScummVM on Windows 10 Pro 6.2.9200.0 64-Bit, everything is in english, and when adding the game to ScummVM 2.1.2 (Mar 31 2020 00:38:13), the log states:

[2020-04-21 21:54:12] Adding to SearchMan: D:\Games\ScummVM\games\King's Quest 4 (Amiga Sounds)\
[2020-04-21 21:54:12] Checking for OBJETS/VS1.HLZ
[2020-04-21 21:54:12] not found
[2020-04-21 21:54:12] The game in 'King's Quest 4 (Amiga Sounds)\' seems to be an unknown game
[2020-04-21 21:54:12] variant.
[2020-04-21 21:54:12]
[2020-04-21 21:54:12] Please report the following data to the ScummVM team at
[2020-04-21 21:54:12] https://bugs.scummvm.org/ along with the name of the game you tried to add and
[2020-04-21 21:54:12] its version, language, etc.:
[2020-04-21 21:54:12]
[2020-04-21 21:54:12] Matched game IDs for the SCI [all games] engine: chest, christmas1992,
[2020-04-21 21:54:12] ecoquest-cd, ecoquest2-demo, freddypharkas-demo, gk1demo, gk1, gk2-demo-win,
[2020-04-21 21:54:12] hoyle4-demo, inndemo, kq6-cd, kq7-win, kquestions, laurabow2-demo, lsl1sci-pl,
[2020-04-21 21:54:12] lsl5-it, lsl6, lsl6hires, lighthouse-demo, mothergoose256, mothergoosehires,
[2020-04-21 21:54:12] pepper, pq1sci, pq3-es, pq4demo, pq4-cd, pqswat-demo, qfg1vga, qfg3-demo,
[2020-04-21 21:54:12] qfg4demo, qfg4, sq6, islandbrain, sci-fanmade
[2020-04-21 21:54:12]
[2020-04-21 21:54:12] {"resource.000", 0, "c5608ac1b27acfd333ee535260dad927", 3207249},
[2020-04-21 21:54:12] {"resource.map", 0, "ee0782b0e610af26c138925ad549b4ee", 5934},

When adding the game to a nightly I recently downloaded, version 2.2.0git4593-gf531eba971 (Apr 20 2020 05:59:17), the log is similar.

ScummVM gives a list of games to add as can be seen in the log. The only one on the list that comes closest is "King's Quest IV: The Perils of Rosella (SCI/Amiga/English)." The result is the same when playing the game in either versions of ScummVM. With the preconfigured settings, I can hear the music in the intro but once it gets to the two men holding trumpets the sound stops and it appears that there's no sound in the rest of the game when walking around. At this point, the log states:

[2020-04-21 21:56:16] WARNING: Bad command or running status 00!
[2020-04-21 21:56:53] WARNING: MIDI parser: the requested SCI0 sound has no MIDI note data for the currently selected sound driver!

I tried adjusting the game settings and seem to have no luck as well. Changing the platform from Amiga to DOS seems to have no effect. Changing my audio settings from MT-32 to Amiga Audio Emulator causes the music in the intro to no longer be heard and then at the screen with the minstrel again I will eventually hear a seagull and then a weird growling noise. At this point, the log states:

[2020-04-21 22:17:24] WARNING: MIDI parser: the requested SCI0 sound has no MIDI note data for the currently selected sound driver!
[2020-04-21 22:17:32] WARNING: MIDI parser: the requested SCI0 sound has no MIDI note data for the currently selected sound driver!
[2020-04-21 22:17:32] WARNING: MIDI parser: the requested SCI0 sound has no MIDI note data for the currently selected sound driver!
[2020-04-21 22:17:47] WARNING: MIDI parser: the requested SCI0 sound has no MIDI note data for the currently selected sound driver!
[2020-04-21 22:17:47] WARNING: MIDI parser: the requested SCI0 sound has no MIDI note data for the currently selected sound driver!
[2020-04-21 22:17:47] WARNING: MIDI parser: the requested SCI0 sound has no MIDI note data for the currently selected sound driver!
[2020-04-21 22:17:48] WARNING: Amiga/Mac driver: invalid instrument -1 on channel 10!
[2020-04-21 22:17:50] WARNING: Amiga/Mac driver: invalid instrument -1 on channel 11!

Another thing I noticed is that under the Engine section when editing the game is that "Skip EGA dithering pass(full color backgrounds) is missing. As for the sound issue,I believe the problem may lie in how this patch provides the audio. The diagnostic log for the game states the following for the game configuration:

videoDrv = MCGA320.DRV
soundDrv = MTSBGUS.DRV
kbdDrv = IBMKBD.DRV
mouseDrv = STDMOUSE.DRV

I have also attached a game save of Rosella standing in front of the minstrel that I spoke of.

[ZvikaZ]

Let's take a step back.

Before discussing how (and if...) to solve the problem, please explain what is the problem.
In other words, what are you trying to achieve?

Can you give an example of something that sounds better with that installer in Dosbox, than the regular unpatched in ScummVM?

Usually, from my experience, ScummVM gives the best results, on the clean original files, without needing any third party patches.

On the other hand, if there is something to improve, it'd be better to do that inside ScummVM, rather than add support to third party patch.

[TarkinMX]

Sorry, what I'm trying to achieve is getting Amiga environmental sounds in the dos version of King's Quest 4. I thought I made had been thorough when submitting the ticket.

The patch adds environmental sounds from the Amiga version because the dos version of the game didn't have any. The dos version has superior music when using MUNT so this patch combined the two. The patch also restores individual day/night palettes that are not present in later versions of the game because Sierra removed them to get the game to fit on a single floppy disk. The earlier versions of the game that have the original palettes play just fine in ScummVM as well.

In this patch, when starting a new game and Rosella is standing at the beach you can hear seagulls and the roar of the ocean when using dosbox. This can also be heard in the Amiga version of the game when playing it in ScummVM. It works just fine in the version of dosbox provided, which is just dosbox with MUNT support, and that's why I had mentioned it. The game looks like it's using a custom sound driver with GUS and MT-32 combined when I looked at the diagnostic log from dosbox but I'm obviously not an expert on these things and not sure how newrisingsun created this patch. I had assumed that the sound support for this would be something that ScummVM could improve upon since I can hear the music just fine when using MT-32 emulation and can kind of hear the environmental sound when switching to Amiga sound emulation even though it's garbled. I can't get both environmental sound and music to play at the same time.

I would think it's safe to say that the patch is in similar fashion as to the idea of the monkey island 1 and 2 unofficial talkie patches which are recognized and play just fine in ScummVM. Also, seeing how unofficial games like Space Quest 0, Space Quest X, and King's Quest 2.5 for example are recognized in ScummVM then I had assumed they have support in some fashion hence my reason for submitting this ticket.

[gabberhead]

3 years later :) will this version be ever supported by scummvm?