MYST3: Video speeds up after room transition

[eriktorbjorn]

When a video is playing as part of a room background, it is paused during transitions between room but the sound (correctly, I assume) keeps playing. To compensate, the video speeds up briefly after each transition. This looks strange to me. It would probably be better if it skipped frames instead. Here is a quick-and-dirty experiment to do so:

diff --git a/engines/myst3/movie.cpp b/engines/myst3/movie.cpp
index bb163e82b8..00eee8832e 100644
--- a/engines/myst3/movie.cpp
+++ b/engines/myst3/movie.cpp
@@ -332,7 +332,7 @@ void ScriptedMovie::update() {
                        }
                }
 
-               if (!_scriptDriven && (_bink.needsUpdate() || _isLastFrame)) {
+               while (!_scriptDriven && (_bink.needsUpdate() || _isLastFrame)) {
                        bool complete = false;
 
                        if (_isLastFrame) {

But for one thing it may not be the best way to do so, and for another I'm afraid it would introduce frame skipping where it's not desired. As I said, it's just an experiment to see the difference.

I'm attaching a savegame of the part where I noticed this.

[macca8]

I would've thought that the video pausing briefly (in your example, when zooming in for a close up) would be more of a distraction than the split-second speed increase that follows when the video resumes, but perhaps your eyes are more sensitive than mine.

However, if you don't mind, I'd like to follow up your forum comment that this was the only issue you encountered while playing the game.
When testing, did you not encounter the Alt+Enter behaviour bug on your system (as described in #12476, and referred to in #12473), or you simply consider it separate to the game?

[eriktorbjorn]

I've made two recording to try and demonstrate what I see:

myst3-catchup.mp4 is what it looks like currently
myst3-skip.mp4 is the quick-and-dirty skipping I added just to test

I find the first one more distracting.

I did not consider the fullscreen bug for my testing, since it seems to be a generic (and very, very annoying) bug for all 3D games with OpenGL renderers. I did try it once, just to see that it still happened. It did. Perhaps fullscreen/windowed switching should be disabled for the release?

I also noticed that there are a handful of other Myst 3 bugs in the bug tracker, obviously from people who know the game better than I do. But my goal was to look for obvious blocking bugs specific to Myst 3 itself.