SCUMM: Re-enable lines in DOTT

[GermanTribun]

In DOTT, there are several lines that are in the MONSTER.SOU but can't be accessed in normal gameplay due to code problems. While the lines with Dr. Fred after getting the diamond are fixed, there are some more.

It is documented here: ​https://tcrf.net/Maniac_Mansion:_Day_of_the_Tentacle/Unused_Scripts
And here: ​https://tcrf.net/Maniac_Mansion:_Day_of_the_Tentacle/Unused_Dialogue

Is it possible to repair those lines so that they appear again (and hopefully they were also translated for other languages)?

Quick overview of those that I think are usable:

​https://tcrf.net/Maniac_Mansion:_Day_of_the_Tentacle/Unused_Dialogue#Field
In the scene when Franklin wants to test his new kite, he actually has a second reaction to Hoagie botching the start of the kite, which is never called upon. Perhaps the script can be modified so that his reactions alternate? Also, the script is overly restrictive and doesn't allow Hoagie to look at the kite and notice a pocket, thus preventing the player from getting a good hint. Perhaps the action of looking at it can be allowed?

​https://tcrf.net/Maniac_Mansion:_Day_of_the_Tentacle/Unused_Scripts#Hoagie.27s_Chron-O-John_Use_Script
Hoagie has special lines for trying to connect an empty battery or a random item. However, due to later scripting to make sure the Chon-o-John only sends items, these lines are not heard and the plug only gives the generic answer. Can the conditions for the special lines instead refer to the plug?

​https://tcrf.net/Maniac_Mansion:_Day_of_the_Tentacle/Unused_Dialogue#Main_Hall_.28past.29
The fire in the fireplace has a code bug that prevents Hogie from trying to interact with it properly, thus also never giving his special answer.

[dwatteau]

Yes, that analysis on tcrf.net is very nice, and I'm working on restoring the most interesting content when it's obvious that it was intended by the authors. As far as I know, these lines have always been translated and dubbed (and even restored in the remaster, but still untriggered). FWIW, I've also found some content to be restored in Monkey2 (even in the Ultimate Talkie Edition).

(I'm not sure we're going to fix/restore the smallest of the smaller issues, though, because at the moment our SCUMM engine doesn't have a proper mechanism for plugging patches, and so workarounds are quite invasive in the code).

ScummVM 2.6.0 will already restore the missing line from Dr. Fred about Hoagie/Laverne when he receives a new diamond.

I also have a fix for the fireplace and Hoagie (​https://github.com/dwatteau/scummvm/commit/0bc2529eae73da596c531876f79c45c02c56c65b) but I haven't submitted it yet, because the problem is caused by a script whose purpose is still unclear to me.

And I'll try to restore some of the other stuff when I can :)

You can check out this wiki page once in a while, we update it whenever we add such enhancements to the daily builds:
​https://wiki.scummvm.org/index.php?title=SCUMM/Game_Enhancements

[dwatteau]

In the scene when Franklin wants to test his new kite, he actually has a second reaction to Hoagie botching the start of the kite, which is never called upon. Perhaps the script can be modified so that his reactions alternate?

Looking at script 9-203, I think the original intent was to have Franklin say the unused line when you push the kite too early (while the used line should only be used if you pushed it too late). It looks like it's just a matter of a SCUMM bit not being properly changed when Franklin says "NOW!", so I may be able to fix that.

Also, the script is overly restrictive and doesn't allow Hoagie to look at the kite and notice a pocket, thus preventing the player from getting a good hint. Perhaps the action of looking at it can be allowed?

Unfortunately, I'm not sure it's going to be easily possible to restore these particular lines.

If I change script 9-205 to restore the usual object interactions (so that you can look at the kite and its pocket), there's a problem because while Hoagie is holding the kite, his temporary costume (no. 36) doesn't have any lip sync feature. Restoring the verb actions would make this very obvious... (You can see this limitation in the original game if you try to talk to one of your objects while holding the kite; Hoagie won't move his lips.)

It's maybe possible to import the missing talking animation from his usual costume, but I personally don't know much about this part of the engine.