AGI: Scalers and shaders to not work correctly when upscaled for Hercules Hires font

[Agozerosu]

Windows 10, ScummVM 2.8.0, OpenGL renderer

In AGI games, when using the Hercules HiRes Font game option as well as any scalers or shaders, ScummVM only applies the shader/scaler effects to the hires game text instead of the game graphics (or in most cases, graphics and text). When the Hercules Hires font is not in use, the shaders and scalers work as intended.

[sluicebox]

Hello! Could you please attach some screenshots demonstrating this, along with the specific games and config settings to reproduce? (You could also include your scummvm.ini with the [scummvm] section and your game's section so we know exactly what your setup is.)

I can't reproduce this, but I don't know much about shaders or scalers. I took a default ScummVM config on windows 7, added Black Cauldron version 2.0, and tried the crt/CRT-beam shader, and then the DotMatrix scaler. The shader had an effect on the entire screen with and without Hercules fonts, then I tried the scaler, and it did too.

Attached is a screenshot of crt/CRT-beam and Hercules font using the 2.8.0 release. (I get same results in daily builds)

The only thing the Hercules font does in AGI is double the internal resolution. I can imagine the source resolution having an effect on the shaders, but it sounds like you're saying they don't work at all?

I will definitely not be the one fixing this, but I doubt this is an AGI issue and I'd like to forward it to the right people. But they'll also need to reproduce it, and right now it looks like it's working to me.

[Agozerosu]

Space Quest II with HQ3x Scaler selected + Hires Hercules font enabled

[Agozerosu]

Space Quest II with HQ3x Scaler selected + Hires Hercules font disabled

[Agozerosu]

Alright, added two screenshots to showcase what I'm seeing on my end. Spotted an error in my file naming; so I'm using the HQ3x shader, not the scaler... The results are the same, however.

Here's the scummvm section of my configuration file:

[scummvm]
filtering=false
scaler=normal
mute=false
window_maximized_width=1920
last_fullscreen_mode_width=1920
renderer=opengl_shaders
multi_midi=false
gui_browser_show_hidden=false
music_driver=mt32
vsync=true
local_server_port=12345
window_maximized=true
gui_browser_native=false
scale_factor=1
window_maximized_height=1001
last_fullscreen_mode_height=1080
mt32_device=mt32
last_window_width=1900
talkspeed=60
gfx_mode=opengl
gui_launcher_chooser=list
gui_scale=100
gui_disable_fixed_font_scaling=false
subtitles=true
browser_lastpath=C:\Users\Aarni\Emulators\ScummVM\schizm\
music_volume=192
opl_driver=auto
aspect_ratio=true
autosave_period=0
grouping=none
native_mt32=false
gui_return_to_launcher_at_exit=true
fullscreen=false
updates_check=0
last_window_height=1001
gm_device=auto
sfx_volume=192
lastselectedgame=sq2
midi_gain=100
discord_rpc=false
gui_saveload_chooser=list
speech_volume=192
gui_use_game_language=false
confirm_exit=false
grid_items_per_row=5
savepath=
tts_voice=0
antialiasing=8
shader=hqx/hq3x.glslp
stretch_mode=fit
tts_enabled=false
versioninfo=2.8.0
speech_mute=false
gui_language=en
enable_gs=false

[sluicebox]

Thanks for the info and screenshots. That's enough for me to see that this is isn't a problem in the AGI engine itself, so now I can set the right component so that the right devs see it.

It looks to me like they're being applied in both cases, but since the input image is a different resolution due to upscaling, the effect is different; in this case it's so subtle as to not do much. I don't know this stuff, but I'm sure the relevant difference is the image resolution and not the fonts themselves. If we had an option to upscale the AGI resolution without using the Hercules font, I expect it would still do the same thing.