Opened 5 months ago

Closed 5 months ago

#15146 closed defect (fixed)

DIRECTOR: Bad palette in The Dark Eye

Reported by: eriktorbjorn Owned by: moralrecordings
Priority: normal Component: Engine: Director
Version: Keywords:
Cc: Game:

Description (last modified by eriktorbjorn)

In The Dark Eye (v1.0/Windows/English), once the game starts the palette is messed up, like this:


I've chosen this screenshot because it demonstrates that certain elements in the image may still have the correct palette. This is a recent regression. Bisecting points to this commit:

bde3fe3f77bb201d4a90d3883a7be7c62435496e is the first bad commit
commit bde3fe3f77bb201d4a90d3883a7be7c62435496e
Author: Scott Percival <code@moral.net.au>
Date:   Tue May 28 16:07:20 2024 +0800

    DIRECTOR: Reset palette in use on movie switch

    Previously if there was a movie switch, and the two movies used
    different custom palettes with the same cast ID, there was no
    mechanism to force a swap to the new palette.

    Fixes palette glitches in Die Hexenakademie.

 engines/director/castmember/palette.cpp |  9 ++++++++-
 engines/director/castmember/palette.h   |  1 +
 engines/director/graphics.cpp           | 28 ++++++++++++++++++++++++++--
 engines/director/window.cpp             |  1 +
 4 files changed, 36 insertions(+), 3 deletions(-)

Attachments (1)

scummvm-darkeye-win-00000.png (221.1 KB ) - added by eriktorbjorn 5 months ago.

Download all attachments as: .zip

Change History (4)

by eriktorbjorn, 5 months ago

comment:1 by eriktorbjorn, 5 months ago

Description: modified (diff)

comment:2 by eriktorbjorn, 5 months ago

Component: --Unset--Engine: Director

comment:3 by eriktorbjorn, 5 months ago

Owner: set to moralrecordings
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.