SCI: SQ4 Korean text not rendered after refactor

[sluicebox]

SQ4CD-Korean text no longer appears on the control panel (score, etc) or in the dialog buttons for Quit or Restart, probably others.

This change happened in ​https://github.com/scummvm/scummvm/pull/6003

Before and After pictures of the Quit dialog attached

[athrxx]

Lind of makes sense that something like this would happen in a situation where PC-98 does not have Japanese text. The PC-98 interpreters do have some code changes for the text control to make sure that the text is not overdrawn. But it is limited to situations where PC-98 needs it.

Hopefully, I can transfer these changes to the button control. I mean there could be two possibilities why SCI1 PC-98 does not have Japanese button controls: The devs found it unnecessary/were too lazy or it was too difficult to do it. Let's hope for the first one... :-)

[athrxx]

Okay, I have made a small fix. My impression is that the text control modifications can indeed be easily transferred to other controls. So I made the changes for the button control.

Are there any test cases for icon, list or text edit controls so that we can see if they also need some updating?

Would be good if someone would actually test this more intensely. When I worked on COMI Korean, I did get feedbck from the ScummKOR guys, but I guess the SCI patches are less common (I didn't even manage to find any other than SQ4). I did test the intro skip buttons and quit buttons for SQ4 Korean and SQ4 and KQ5 PC-98, but there might be trickier situation than that...

[sluicebox]

The buttons on Quit/Restart dialogs work again. I also tried the original save/restore dialogs, and those buttons are fixed too. (The input textbox on the save dialog doesn't seem to be a part of the Korean patch either way; it's always behaved normally.)

kDisplay calls don't appear to be drawing anything. This is easiest to test on the control panel screen (screenshots attached), but it also occurs wherever text is drawn directly to the game screen (usually with colors in the original) instead of over the gray message box. Use the debugger to warp to monolith burger (room 386) and every time the manager talks, there should be text on the screen. Clicking talk on him gets a long message.

I'm trying to think where else there's interesting text in this game to test... the hintbook? But I think it's all kDisplay.

[athrxx]

I think kDisplay would affect the PC-98 version, too (unless it has English text there). So maybe I can fix it from the original interpreter disasm.

[athrxx]

Interesting, for PC-98 this is not an issue. It uses a low-res font here. Which also means that the original interpreter does not have a fix for kDisplay.
Fortunately, it can be fixed in the same way as the controls. I am going to make a commit later...