Opened 7 weeks ago

Closed 2 weeks ago

#15392 closed defect (fixed)

BACKENDS: FS: Make file writing atomic commit breaks saving changes to files in ScummVM Windows Roaming folder

Reported by: necros2k7 Owned by: lephilousophe
Priority: blocker Component: Port: Win64
Version: Keywords: win64, windows, backend, fs
Cc: Game:

Description (last modified by necros2k7)

WARNING: Couldn't save file C:\Users\PC\AppData\Roaming\ScummVM\scummvm.ini!
win11 24h2
bug present from 8821 daily build

Change History (7)

comment:1 by necros2k7, 7 weeks ago

Summary: BACKENDS: FS: Make file writing atomic - breaks saving changes to scummvm.ini → BACKENDS: FS: Make file writing atomic commit breaks saving changes to scummvm.ini

comment:2 by necros2k7, 7 weeks ago

Description: modified (diff)

comment:3 by necros2k7, 7 weeks ago

Summary: BACKENDS: FS: Make file writing atomic commit breaks saving changes to scummvm.ini → BACKENDS: FS: Make file writing atomic commit breaks saving changes to files in Windows Roaming folder

comment:4 by sluicebox, 7 weeks ago

Priority: normal → blocker

comment:5 by Le Philousophe <lephilousophe@…>, 7 weeks ago

In 0c60d296:

Revert "BACKENDS: FS: Make file writing atomic"

This reverts commit 99dc7641a998cc26fa2aa6eaf0c55f22f4722e33.
This causes bug #15392, a build failure on Dreamcast and changes too
much the semantics.
A better approach will need to be found, especially for streaming files
like logs.

comment:6 by necros2k7, 7 weeks ago

Summary: BACKENDS: FS: Make file writing atomic commit breaks saving changes to files in Windows Roaming folder → BACKENDS: FS: Make file writing atomic commit breaks saving changes to files in ScummVM Windows Roaming folder

comment:7 by bluegr, 2 weeks ago

Owner: set to lephilousophe
Resolution: → fixed
Status: new → closed

This is obsolete now - the feature has been fixed with this PR, and no longer occurs:
​https://github.com/scummvm/scummvm/pull/6187

Closing as fixed

Note: See TracTickets for help on using tickets.