SCUMM: Loom (EGA) - Game not starting/unrecognized after the use of scummtr and scummrp with the MT32 update

[gabberhead]

i think, i found a bugin scummvm. i am using scummtr and scummrp for editing the german version of loom with the mt-32 update. when i make changes to the game, and import it, scummvm gives an error: gamefiles not found. and the game can also not be added to scummvm again: scummvm can not find a game error. but when i delete the needed files for the mt32 update 82 83 84 85.lfl, the game starts again with the same files and also can be added to scummvm without any problem. but only with ad-lib sound of course.
i tested the same files with dosbox incl the mt32 needed files, the game starts without problems, and also with mt32 music.
the same problem occurs, when i do the same changes to the english version.
and the same also happens, when u export and import it without any changes.
first i thought, it is a problem with scummtr or scummrp, but the problem is scummvm itself like it looks.

[gabberhead]

The same problem i also have with monkey Island 1 vga dos. Ega dos, CD dos, ultimate talkie versions are working, after using of those Tools. It looks like the fallback detection of scummvm is not working right on those to games. Because for example, mi1 is working with dosbox without a problem and also with mt32 music. Mi1 over scummvm is starting, but with mt32 error and then adlib as fallback, but the graphics are corrupted, and after the Intro the game crashes. Dwa wrote on his github site where u can download those tools, that it looks like, mi1 vga is recognized as ega Version, after modifying. And that lead into the problems. Perhaps, loom Haß the same problem. But loom I didnt test with dosbox.

[gabberhead]

double post...

[gabberhead]

The same problem i also have with monkey Island 1 vga dos. Ega dos, CD dos, ultimate talkie versions are working, after using of those Tools. It looks like the fallback detection of scummvm is not working right on those to games. Because for example, the same modyfied version of mi1 is working with dosbox without a problem and also with mt32 music. Mi1 over scummvm is starting, but with mt32 error and then adlib as fallback, but the graphics are corrupted, and after the Intro the game crashes. Dwa wrote on his github site where u can download those tools, that it looks like, mi1 vga is recognized as ega Version, after modifying. And that lead into the problems. Perhaps, loom has A similar problem. But loom I didnt test with dosbox.

[dwatteau]

To me, it’s a matter of improving some logic in engines/scumm/detection_internal.h.

The rest of the team may not be interested in spending time on this, but I do have interest in fixing this type of problems. Improving this code would help translation work (otherwise some games such as Monkey1 VGA V4 just become completely unplayable and glitched in ScummVM while you work on your translation). See ​https://user-images.githubusercontent.com/9024526/153197013-b519f5b7-6bb6-4938-8fdd-dbe8aa9b6dbd.png as an example (doesn’t glitch in the original interpreter – the problem happens because the fallback detection code doesn’t recognize that it’s the VGA floppy release).

Anyway, assigning this to myself – let’s keep this issue open. I can’t say when I may be able to work on it, though.

[gabberhead]

If u need some testing, u can contact me :)