SCUMM: Detection of Mac version of MI1 from the LucasArts Mac CD Game Pack is broken when using Dumper Companion

[eriktorbjorn]

To verify that the Mac versions of the SCUMM games still work, I re-dumped the files using the ScummVM dumper companion. I tried all the games from the two Mac CD Game Packs, as well as my Fate of Atlantis CD. They were all detected, except for Monkey Island 1 from the first game pack.

I tried dumping both with and without Unicode support, but that doesn't make any difference for this particular game. Both yield the following files:

• MONKEY1.000
• MONKEY2.000
• MONKEY3.000
• MONKEY4.000
• MONKEY5.000
• Monkey Island

The game gets detected as any of:

• The Secret of Monkey Island (CD)
• The Secret of Monkey Island (Mac)
• The Secret of Monkey Island (FM-TOWNS/FM-TOWNS)
• The Secret of Monkey Island (SEGA/SegaCD)
• The Secret of Monkey Island (SE Talkie)

I picked the Mac one, but there's obviously something wrong here because when I run it it first complains that the game should have audio tracks (it doesn't), and then it crashes with a "Bad ID 69622426('ib$&') found in index file directory!" error.

This is probably a regression from when I tried to fix the detection entries. Interestingly, the one from the second Mac Games pack (which has only MONKEY1.000, MONKEY1.001, and Monkey Island) is unambiguously detected and works fine.

It's probably some minor mistake I made. But even if I find the time to look, I won't be able to commit anything until this evening at the earliest. And it's a pretty bad bug to have at this stage, so I'm filing a bug report in case anyone else wants to look at it before I can.

Is this something that needs addressing before 2.9.0?

[eriktorbjorn]

Wait a minute...

For all the games, Dumper Companion extracts the data files (MONKEY1.000, etc.) as raw data.

Except for Monkey Island on the first pack, where the files get extracted as MacBinary (creator 'Mky1', type '.LFL').

So apparently the files have a small resource fork? That's awkward. If I re-copy the MONKEY1.* files as raw data, the game detects and runs just fine. I'm not sure how to handle this.

[eriktorbjorn]

Judging by ResEdit, the resource forks for these files are actually empty. According to hfsutils the resource forks are 286 bytes each, but maybe that's just the overhead of having a resource fork to begin with?