Opened 20 years ago

Closed 20 years ago

#1726 closed defect

DIG: Subtitle position in Asteroid Lander game (Regression)

Reported by: Kirben Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: The Dig

Description

Latest ScummVM cvs version. Compiled under mingw with GCC 3.4.0 and running under Windows XP. English version of The Dig (PC)

Part of the subtitles of responses after a crash in the Asteroid Lander mini game are often displayed behind the background text lines. The 'X/Y Vel' and 'Fuel' lines are drawn as blastText by script 299. The response after crash of Asteroid Lander are drawn as regular text by script 301. Screenshot attached, along with scripts output.

Ticket imported from: #1010520. Ticket imported from: bugs/1726.

Attachments (7)

glitch.png​ (2.6 KB ) - added by Kirben 20 years ago.
Screenshot of glitch
script-301.txt​ (2.3 KB ) - added by Kirben 20 years ago.
Script 301
script-299.txt​ (1.2 KB ) - added by Kirben 20 years ago.
Script 299
original.png​ (1.8 KB ) - added by Kirben 20 years ago.
Screenshot of original Dig
subtitle.txt​ (984 bytes ) - added by Kirben 20 years ago.
Patch of code change as example only
orig.txt​ (1.2 KB ) - added by Kirben 20 years ago.
Patch of small differences compared to disasm.
original_dig.zip​ (9.5 KB ) - added by Kirben 20 years ago.
Screenshots from original

Download all attachments as: .zip

Change History (18)

by Kirben, 20 years ago

Attachment: glitch.png​ added

Screenshot of glitch

by Kirben, 20 years ago

Attachment: script-301.txt​ added

Script 301

by Kirben, 20 years ago

Attachment: script-299.txt​ added

Script 299

by Kirben, 20 years ago

Attachment: original.png​ added

Screenshot of original Dig

comment:1 by Kirben, 20 years ago

Just compared the original Dig and attached screen. Seems like the problem is the subtitles should be divided into several lines and not overlap background text.

comment:2 by Kirben, 20 years ago

ScummVM 0.6.0 wrapped the subtitles responses correctly, so it is a regression.

comment:3 by Kirben, 20 years ago

Summary: DIG: Subtitles partially hidden in Asteroid Lander mini game → DIG: Subtitle position in Asteroid Lander game (Regression)

by Kirben, 20 years ago

Attachment: subtitle.txt​ added

Patch of code change as example only

comment:4 by Kirben, 20 years ago

Owner: set to fingolfin

comment:5 by Kirben, 20 years ago

The lack of subtitle wrapping seems to be caused by scumm/string.cpp revision 1.210 by fingolfin. Reverting that change fixes the wrapping of subtitle lines in response but their x/y position becomes wrong (Unless I remove _screenTop check in same section of code). See patch to see exactly when I mean.

fingolfin , any ideas ?

by Kirben, 20 years ago

Attachment: orig.txt​ added

Patch of small differences compared to disasm.

comment:6 by Kirben, 20 years ago

Attached patch of small differences for that section of charset_1(), compared to original Dig disasm, which might be helpful.

comment:7 by Kirben, 20 years ago

I added corrections from disasm., since they: Fix subtitle wrapping in many locations Fix subtitles in dig demo (Was broken again)

The position of subtitle responses in Asteroid Lander still isn't quite right, sometimes the x position is still wrong. Still looking into it...

comment:8 by fingolfin, 20 years ago

Can you be a bit more specific: the x position of what is wrong, exactly? How can I reproduce it?

by Kirben, 20 years ago

Attachment: original_dig.zip​ added

Screenshots from original

comment:9 by Kirben, 20 years ago

Just crash the lander several times and you will notice the subtitles of response are often too far to the right and not wrapped correctly. Attached screenshots of each response in original Dig, which make it easier to spot difference.

comment:10 by fingolfin, 20 years ago

As a matter of fact, no, I never see the subtitles being too far to the right!

However I did notice that the X Vel etc. display in ScummVM as farther to the left than in the original; more precisely, we center, they don't. I assume that this is the different between o6_kernelSetFunctions case 16 and 17, so i changed the code. Now what I get matches the original engine perfectly.

Anyway, if you could add a screenshot of ScummVM showing the glitches you are talking about, that might be more helpful than showing screenshots of the original, at least as long as I simply can't reproduce your report :-/

comment:11 by fingolfin, 20 years ago

Status: new → closed
Note: See TracTickets for help on using tickets.