Opened 23 years ago

Closed 23 years ago

Last modified 23 years ago

#234 closed defect (fixed)

Loom CD Audio won't play with MAD on

Reported by: SF/cccp_99 Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Loom

Description

If ScummVM is compiled with MP3 support using the MAD library, CD audio in Loom won't play. However, when it's compiled without MAD, it plays fine. I've just tested it with the latest source (build 20020507). This bug appeared sometime in the last month, because Loom CD audio was working fine with the April 7th build.

CCCP

Ticket imported from: #553570. Ticket imported from: bugs/234.

Attachments (1)

script_v1.cpp (58.2 KB ) - added by SF/cccp_99 23 years ago.
Fixed Loom CD Audio not playing when MP3 audio is enabled.

Download all attachments as: .zip

Change History (5)

by SF/cccp_99, 23 years ago

Attachment: script_v1.cpp added

Fixed Loom CD Audio not playing when MP3 audio is enabled.

comment:1 by SF/cccp_99, 23 years ago

Component: Engine: SCUMM
Game: Loom

comment:2 by SF/cccp_99, 23 years ago

I've found the problem, and fixed it. Loom's Audio was playing ONLY if COMPRESSED_SOUND_FILE was not defined, but it should have played if the MP3 track was not found. See the fixed attached file, lines 2716-2718

CCCP

comment:3 by SF/ender, 23 years ago

Thanks, change has been commited.

Um, in the future, ATTACH DIFFS. Attaching the whole script file for a two line change is very very annoying :)

comment:4 by SF/ender, 23 years ago

Owner: set to SF/ender
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.