#2539 closed defect (fixed)
COMI: Verb strings aren't wrapped
| Reported by: | lordhoto | Owned by: | cyxx |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Monkey Island 3 |
Description
Hi,
I played COMI (German version) with a SVN checkout from 16.03.2006 on linux (x86). Sometimes if the texts while talking to somebody are missing the linebreaks that's why it's impossibe to read all of the text. Screenshot included.
Ticket imported from: #1452272. Ticket imported from: bugs/2539.
Attachments (7)
Change History (16)
by , 19 years ago
| Attachment: | comi-textbug.png added |
|---|
comment:1 by , 19 years ago
The original game would compare the strings length and screen width in drawVerb(), spliting verb's string into two lines when required. Also the verb line spacing setting was used, when the verb's string was split into two lines.
comment:2 by , 19 years ago
| Summary: | COMI: Textselection misses linebreaks → COMI: Verb strings aren't wrapped |
|---|
comment:3 by , 19 years ago
| Owner: | set to |
|---|
comment:4 by , 19 years ago
I added patch to solve the line wrapping problems with verbs, based on code of original game. But the next verb after a line wrap, is often placed on top of the wrapped line, when using patch.
comment:5 by , 18 years ago
What's wrong exactly with your patch, Kirben ? I modified my datafiles locally to have a test-case and didn't experience any special glitch.
I did some minor changes to that patch, though : - removed the space character at the beginning of the wrapped line - made the check specific to v8 (dig and ft don't seem to handle this) - initialised the _verbLineSpacing to the same value as the original COMI
by , 18 years ago
| Attachment: | comi-french-wrapline-testcase.png added |
|---|
Test-case screenshot, patch v2 applied
comment:6 by , 18 years ago
If a verb line is wrapped, the next verb will be placed over the wrapped part of last verb.
I attached an example of the problem from the German version.
comment:7 by , 18 years ago
Found some possible problems : - o8_getStringWidth() should use the specified charset directly - if we set a new charset in drawVerb(), we should probably restore the previous one.
Updated patch.
comment:8 by , 18 years ago
The verbs are wrapped correctly in German version of COMI now, I commited updated patch to ScummVM SVN.
comment:9 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
screenshot