#2788 closed defect (fixed)
ALL: Engine creates launcher entry when failing to launch
| Reported by: | salty-horse | Owned by: | bgK |
|---|---|---|---|
| Priority: | high | Component: | GUI |
| Version: | Keywords: | ||
| Cc: | raziel_nosgoth@… | Game: |
Description
Using current svn.
When launching scummvm with a target name that is not defined in .scummvmrc, it is searching the current directory.
When the following targets are not defined, they show a "game data not found" error, then return to launcher with new entries created for them: feeble simon1 simon2
The SWORD1 engine correctly displays a "files not found" error, but does not create a new entry. Perhaps that behaviour can be copied to the Simon engine easily.
Ticket imported from: #1544799. Ticket imported from: bugs/2788.
Change History (22)
comment:1 by , 18 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:2 by , 16 years ago
| Owner: | removed |
|---|---|
| Resolution: | fixed |
| Status: | closed → new |
comment:3 by , 16 years ago
comment:4 by , 16 years ago
This tracker item is pending response by the submitter; we cannot continue processing it before that happens. As a consequence, its status has been set to "Pending". It will automatically revert to "Open" once a new comment is made to this item. If no response is made within 14 days, it will automatically be closed.
Thank you.
comment:5 by , 16 years ago
| Status: | new → pending |
|---|
comment:6 by , 16 years ago
| Status: | pending → new |
|---|
comment:8 by , 16 years ago
| Priority: | normal → high |
|---|
comment:10 by , 16 years ago
| Owner: | set to |
|---|
comment:12 by , 16 years ago
| Owner: | removed |
|---|
comment:13 by , 16 years ago
To clarify, the problem occurs with any target this time, and isn't specific to AGOS engine.
I suspect it could be related to merger of detection code in past, but no idea on the exact cause this time around.
comment:14 by , 16 years ago
| Component: | Engine: AGOS → --Unset-- |
|---|---|
| Game: | Simon the Sorcerer 1 |
| Summary: | SIMON: Engine creates launcher entry when failing to launch → ALL: Engine creates launcher entry when failing to launch |
comment:15 by , 16 years ago
The new launcher entry is not saved after quitting, so the bug isn't that bad.
I did some research: The gameid in the command line is set as the config domain. base/main.cpp:detectPlugin() then sets the "gameid".
When the game execution fails in runGame(), the launcher appears. gui/launcher.cpp::updateListing() encounters the new domain. Since it has a gameid but no description, it fetches the default description.
Somewhere after the runGame failure, the domain should be removed. The problem is, how to differentiate between existing entries (with domains) that failed to launch, and this new "dummy" domain that failed to launch?
comment:17 by , 16 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:18 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → new |
This doesn't appear to be fixed, possible duplicate in #10334.
comment:19 by , 7 years ago
As I understand it, the implemented workaround only works for engines which use the advanced detector so this is still broken for all (?) other engines, including SCUMM.
Do we have to duplicate the workaround for all non-AD engines or can we solve this in a more elegant way? Why do we allow specifying a gameid without --path in the first place? What is supposed to happen in this case?
comment:20 by , 7 years ago
| Cc: | added |
|---|
comment:21 by , 6 years ago
| Owner: | changed from to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
This should now be fixed by commit 643ce81cf7.
comment:22 by , 6 years ago
| Component: | --Unset-- → GUI |
|---|
Does it still occur in SVN?