Opened 13 years ago

Last modified 4 years ago

#5730 new defect

AGI: Winnie: Color flood fill issue

Reported by: SF/thunderforge8 Owned by: m-kiewitz
Priority: normal Component: Engine: AGI
Version: Keywords:
Cc: Game: PreAGI

Description

Mac OS X ScummVM 1.3.0 English DOS Winnie the Pooh in the Hundred Acre Wood

When playing the game and picking up the coat, which is purple in color, dropping it on a screen that has a white background causes the white background to become purple. I saw this on a number of screens, but the most obvious was on the map with Roo. He is surrounded by white sand, but dropping the coat makes it all turn the same color as the purple coat until it is picked back up.

Ticket imported from: #3309941. Ticket imported from: bugs/5730.

Attachments (3)

SCI Winnie Correct Palette.jpg (51.7 KB ) - added by SF/thunderforge8 13 years ago.
Screenshot with correct palette before dropping the coat
SCI Winnie Incorrect Palette.jpg (52.6 KB ) - added by SF/thunderforge8 13 years ago.
Screenshot with incorrect palette after dropping the coat
savegame (71 bytes ) - added by SF/thunderforge8 13 years ago.
Savegame with the coat

Download all attachments as: .zip

Change History (16)

by SF/thunderforge8, 13 years ago

Screenshot with correct palette before dropping the coat

by SF/thunderforge8, 13 years ago

Screenshot with incorrect palette after dropping the coat

comment:1 by bluegr, 13 years ago

Summary: SCI: Winnie: Color Palette IssueAGI: Winnie: Color Palette Issue

by SF/thunderforge8, 13 years ago

Attachment: savegame added

Savegame with the coat

comment:2 by SF/thunderforge8, 13 years ago

Added a savegame where the player already has picked up the coat. (Look in the toychest at the start of the game to load the save). You can drop it in the starting room to see a small graphics glitch of this sort in the bottom corner. To get to Roo's screen as shown in the attached screenshots, go West, North, North, North, North.

comment:3 by SF/mthreepwood, 13 years ago

Owner: set to SF/mthreepwood

comment:4 by SF/mthreepwood, 13 years ago

This isn't a palette issue (the game's palette never changes). This looks like a flood fill issue where our picture code continues to fill in the pink color beyond the edge of the coat (there's a gap in the black outline and it spills out into the white of the ground).

comment:5 by sev-, 13 years ago

Priority: normalhigh

comment:6 by sev-, 13 years ago

This bug is nice to get fixed before the release. Raising priority for keeping the track.

comment:7 by bluegr, 13 years ago

Summary: AGI: Winnie: Color Palette IssueAGI: Winnie: Color flood fill issue

comment:8 by bluegr, 13 years ago

Updated description, this is a flood fill issue

comment:9 by SF/mthreepwood, 10 years ago

As far as I can tell, our flood fill routine is pretty wrong here altogether. If you notice, the dark green color of the grass and trees isn't present in the screenshot either. That is, except for one pixel in the grass, which is the point where the fill starts. It sees it's surrounded by black pixels, and bails out. We should check the NAGI implementation and see if that's better, or see if winnie does something different and only uses priority for fill.

comment:10 by sev-, 9 years ago

Component: Engine: AGI
Game: PreAGI
Owner: changed from SF/mthreepwood to m-kiewitz

comment:11 by Mataniko, 7 years ago

This still reproduces in 2.0.0

comment:12 by sev-, 4 years ago

Priority: highnormal

comment:13 by m-kiewitz, 4 years ago

This has to be a difference with floodfill either in all of preAGI, or just this game.
The current AGI implementation in ScummVM is exactly like AGI does it as far as I know.

Note: See TracTickets for help on using tickets.