Opened 12 years ago

Closed 12 years ago

Last modified 5 days ago

#6240 closed defect (fixed)

OS X - CoreAudio midi driver SDK 10.5 problem

Reported by: SF/dominus Owned by: SF/mthreepwood
Priority: normal Component: Port: Mac OS X
Version: Keywords:
Cc: Game:

Description

Hi,

when you built for i386 against SDK 10.5 this will fail as "AudioComponentDescription" does not exist in the SDK. I solved this by adding OS X 10.5 to the USE_DEPRECATED_COREAUDIO_API definition by changing #if TARGET_CPU_PPC || TARGET_CPU_PPC64 || !defined(MAC_OS_X_VERSION_10_6) to #if (MAC_OS_X_VERSION_MAX_ALLOWED < 1060)

This might need fine tuning since the new way to load a soundfont is valid for 10.5 but not <10.5...

Ticket imported from: #3602452. Ticket imported from: bugs/6240.

Change History (9)

comment:1 by SF/dominus, 12 years ago

I'm sorry to be unclear. It doesn't fail, it's just that you could compile with the undeprecated stuff, except for the "AudioComponentDescription" part. Looking too much at coreaudio code today :)

comment:2 by SF/mthreepwood, 12 years ago

Owner: set to SF/mthreepwood

comment:3 by SF/mthreepwood, 12 years ago

The deprecation part isn't really a bug. I'm waiting on Dominus to report back on soundfonts on 10.5 which he said he'll do tomorrow.

comment:4 by SF/dominus, 12 years ago

if you compile ScummVm git against 10.5 SDK in 32bit loading a custom soundfont will fail, when run in 10.8 otoh, soundfont loading done with FSRef instead of FSSpec works fine in 10.4 ppc, so I'd suggest using FSRef for that OR make a 10.5 compile use the new soundfont code via cfsurl

comment:5 by SF/mthreepwood, 12 years ago

Fixed in 412ac740aa04428251a94073357f5458ed217f3f

comment:6 by SF/mthreepwood, 12 years ago

Resolution: fixed
Status: newclosed

comment:7 by digitall, 6 years ago

Component: Port: Mac OS X

comment:8 by Filippos Karapetis <bluegr@…>, 5 days ago

In fb8f1b24:

SCUMM: MACGUI: Don't initialize Mac GUI when it's not activated

Authored by @AndywinXp as a better alternative to the changes done in
PR #6240.

This way, games without original gui active never even attempt to
communicate with _macGui. This also disables _macScreen.

comment:9 by Filippos Karapetis <bluegr@…>, 5 days ago

In 30c7fafa:

SCUMM: MACGUI: Don't initialize Mac GUI when it's not activated

Authored by @AndywinXp as a better alternative to the changes done in
PR #6240.

This way, games without original gui active never even attempt to
communicate with _macGui. This also disables _macScreen.

Note: See TracTickets for help on using tickets.