#6494 closed defect (fixed)
TEENAGENT: Yet another unimplemented callback
| Reported by: | SF/mrugiero | Owned by: | digitall |
|---|---|---|---|
| Priority: | normal | Component: | Engine: TeenAgent |
| Version: | Keywords: | ||
| Cc: | Game: | TeenAgent |
Description
This time built from git current, in the second chapter, next to a squirrel in a tree there is a nut. If you try to examine the nut, you get the unimplemented callback 0x5634. I provide a savegame to reproduce it.
Ticket imported from: bugs/6494.
Attachments (3)
Change History (13)
by , 11 years ago
| Attachment: | teenagent.01 added |
|---|
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Another one, using the chainsaw on the branch, in the back of the mansion. Callback 0x830b.
by , 11 years ago
| Attachment: | callback0x830b.patch added |
|---|
by , 11 years ago
| Attachment: | warning.patch added |
|---|
comment:4 by , 11 years ago
Added a patch for substituting the missing callback errors for a warning.
comment:5 by , 11 years ago
I think the main issue with a warning is that nearly no user would ever see such a warning because it's only printed in the log and/or on stderr. As a result we wouldn't get bug reports like this.
comment:6 by , 11 years ago
| Owner: | set to |
|---|
comment:7 by , 11 years ago
As Lordhoto said, unimplemented callbacks now trigger error() rather than warning() to ensure we get user feedback such as this.
The original hacky decoding for dealing with them was removed in 31cb5ce3f1e970699318e1c7cbfe1ae57804a14c. I had thought I had got all the missing ones, but it appears I missed a few. Will fix these two.
comment:8 by , 11 years ago
Fixed both missing callbacks in commit 4df249b9cec6c9d4ecc0aa8129beb816379d77fa. Closing this bug as fixed.
Mario, please test with the next nightly build / git build and feel free to reopen this if you get any more missing callback errors.
comment:9 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:10 by , 6 years ago
| Component: | → Engine: TeenAgent |
|---|---|
| Game: | → TeenAgent |
Also, may I advise to change the error for the unimplemented cases to a warning? That would be less disruptive.