Opened 22 years ago

Closed 22 years ago

Last modified 6 years ago

#8192 closed patch

CMI: Maybe fix for end credits crash

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Monkey Island 3

Description

While testing the blast text changes in the object line patch, I encountered a crash in the CMI end credits a few times. I could never find a reliable way to trigger it - it never happened unless I used the scalers - but I was able to catch it in the debugger once.

I think what's happening is that NutRenderer::drawChar() is drawing outside the buffer. The y + ty < 0 case that I added definitely does happen as the text scrolls off the screen. I'm not entirely sure about this, but at least it shouldn't hurt.

Ticket imported from: #713149. Ticket imported from: patches/297.

Attachments (1)

nut-renderer-fix.diff (590 bytes ) - added by eriktorbjorn 22 years ago.
Patch against a March 31 CVS snapshot

Download all attachments as: .zip

Change History (3)

by eriktorbjorn, 22 years ago

Attachment: nut-renderer-fix.diff added

Patch against a March 31 CVS snapshot

comment:1 by fingolfin, 22 years ago

Owner: set to fingolfin
Status: newclosed

comment:2 by digitall, 6 years ago

Component: Engine: SCUMM
Game: Monkey Island 3
Note: See TracTickets for help on using tickets.