#8193 closed patch
Fix for bug #695654 ("MI2: Wrong palette during diving")
| Reported by: | eriktorbjorn | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Monkey Island 2 |
Description
I already attached this to the bug report, but I guess I should post it here as well, for better visibility.
This patch aims to fix a palette problem with scrollEffect() in MI2.
Ticket imported from: #713946. Ticket imported from: patches/298.
Attachments (1)
Change History (10)
by , 22 years ago
| Attachment: | mi2-diving-fix.diff added |
|---|
comment:1 by , 22 years ago
The other methods also call updatePalette(), namely dissolveEffect and transitionEffect (the last one even calls it repeatedly, which seems to be redundant). So I really wonder, should we maybe just call updatePaleete() once at the start of fadeIn/fadeOut?
comment:2 by , 22 years ago
Sounds good to me. It was rather late at night when I finally got to the problem area, so I didn't think that far myself.
comment:3 by , 22 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:4 by , 22 years ago
I used a different fix than this, by doing as I suggested (i.e. putting hte calls to updatePalette directly into fadeOut / fadeIn).
comment:5 by , 22 years ago
| Owner: | removed |
|---|---|
| Status: | closed → new |
comment:6 by , 22 years ago
Sounds good to me. It was rather late at night when I finally got to the problem area, so I didn't think that far myself.
comment:7 by , 22 years ago
Oops, I think my browser must have decided to re-post the old status. Closing again.
comment:8 by , 22 years ago
| Status: | new → closed |
|---|
comment:9 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|---|
| Game: | → Monkey Island 2 |
Patch against an April 1 CVS shapshot