#8969 closed patch
PS2: hashmap workaround
Reported by: | sunmax | Owned by: | sunmax |
---|---|---|---|
Priority: | normal | Component: | Port: PS2 |
Version: | Keywords: | ||
Cc: | Game: |
Description
Special #ifdef for PS2 vintage gcc to allow hashmap in branch 0.13.x and trunk to compile.
Ticket imported from: #2659821. Ticket imported from: patches/1074.
Attachments (2)
Change History (13)
by , 16 years ago
Attachment: | ps2-hashmap.patch added |
---|
comment:1 by , 16 years ago
Summary: | PS2 : hashmap workaround → PS2: hashmap workaround |
---|
comment:2 by , 16 years ago
This patch is of course not very nice, since it has to add #ifdef tricks to hashmap.h. Well, we didn't see a better solution, so what...
But at the very very least, when adding such a hack, there should be a comment next to it explaining it. Something like: // Workaround a bug in GCC X.Y.Z in the PS2SDK, which generates an ICE/compile error/earth quake when we call the constructor of _defaultVal explicitly.
comment:3 by , 16 years ago
I.e. I am asking you to submit a revised patch which adds such an explanatory comment. Other than that, well, I am not happy with this solution, but we have similar hacks around other compiler bugs, so...
by , 16 years ago
Attachment: | ps2-hashmap-new.patch added |
---|
comment:4 by , 16 years ago
Aye Max,
revised patch in tracker.
Let me know if you like this better so I will commit to trunk and 0.13.0
ciao, -max File Added: ps2-hashmap-new.patch
comment:7 by , 16 years ago
Owner: | set to |
---|
comment:9 by , 16 years ago
Status: | new → closed |
---|
comment:11 by , 6 years ago
Component: | → Port: PS2 |
---|
ps2-hashmap.patch