#9128 closed patch
SOMI: Kanji support for japanese MegaCD version
| Reported by: | SF/tobigun | Owned by: | sev- |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Monkey Island 1 |
Description
This patch adds support for the Kanji font in the japanese MegaCD version of Secret of Monkey Island. The Kanji font is stored in charset 5.
Ticket imported from: #2923628. Ticket imported from: patches/1233.
Attachments (1)
Change History (6)
by , 15 years ago
| Attachment: | monkey_segacd_kanji.patch added |
|---|
comment:1 by , 15 years ago
comment:2 by , 15 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:3 by , 15 years ago
One small thing. GCC warned about the following line:
idx = ((idx & 0x7F) << 8) | ((idx >> 8) & 0xFF) - 1;
It said, "suggest parentheses around arithmetic in operand of ‘|’", and I think I'd have to agree with that. I'm not sure if this is supposed to mean (X | (Y - 1)) or ((X | Y) - 1). Operator precedence makes it the former, but the latter seems more likely to me. (It makes a difference if Y is 0.)
comment:4 by , 15 years ago
Thanks eriktorbjorn. I thought i typed ((X | Y) - 1) but the large amount of parantheses made me a little bit confused. The correct line should be
idx = (((idx & 0x7F) << 8) | ((idx >> 8) & 0xFF)) - 1;
comment:5 by , 6 years ago
| Component: | → Engine: SCUMM |
|---|---|
| Game: | → Monkey Island 1 |
Excellent! Committed as is.